Uploaded image for project: 'In-Portal CMS'
  1. In-Portal CMS
  2. INP-295

Form modification detector (it's php part) works strange

    XMLWordPrintable

    Details

    • External issue URL:
    • Additional information:
      Hide

      We have field named "Modified" in certain tables (including category items), that holds last modification date of and database record. There are several problems in current implementation:

      • field is updated no matter was something changed or not;
      • field is always updated no matter what user have entered on editing template.

      I propose to fix that by:

      • check that other fields (except that Modified) field were changed before changing it
      • make Modified field on editing form as label, since user entered value will be always ignored.

      Same about ModifiedById field around the system.

      Show
      We have field named "Modified" in certain tables (including category items), that holds last modification date of and database record. There are several problems in current implementation: field is updated no matter was something changed or not; field is always updated no matter what user have entered on editing template. I propose to fix that by: check that other fields (except that Modified) field were changed before changing it make Modified field on editing form as label, since user entered value will be always ignored. Same about ModifiedById field around the system.
    • External issue ID:
      357
    • Copy Issue Key:
    • Patch Instructions:

      Patches must be submitted through Phabricator.

      Description

      When I open link (in catalog) for editing and click on "General" tab without changing anything, then message "Modifications will not take effect until you click the Save button!" is shown, but I didn't change a thing.

      It is possible, that something I don't see on form was changed, but then such fields shouldn't cause such warning message to appear.

      It's possible, that other forms also have same behavior.

        Attachments

          Issue Links

          child of

          Feature Request - A new feature of the product, which has yet to be developed. INP-88 Implement "MemCached" functionality

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          parent of

          Bug Report - A problem which impairs or prevents the functions of the product. MINL-9 Fatal error when Modifying Pending Link on Front-end

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          relates to

          Bug Report - A problem which impairs or prevents the functions of the product. INP-461 Issues with change log section

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Bug Report - A problem which impairs or prevents the functions of the product. MINC-41 Wrong calculation of HasRequiredOptions field resulting additional change log record

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          mentioned in

          Page Loading...

            Activity

              People

              • Assignee:
                alex Alex
                Reporter:
                alex Alex
                Developer:
                Alex
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: