[INP-45] Get rid of safeDefine function usage when possible - In-Portal Issue Tracker

XML

Word

Printable

Details

Type: Bug Report
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 5.1.0
Fix Version/s: 5.2.0-B1
Component/s: Optimization
Labels:
None

External issue URL:
http://tracker.in-portal.org/view.php?id=55
Additional information:

Hide

There should be explanation provided for every safeDefine replaced by define.

Show
There should be explanation provided for every safeDefine replaced by define.
Story Points:
1
External issue ID:
55
Copy Issue Key:
Patch Instructions:
Patches must be submitted through Phabricator.
- To submit patch via Command Line use Patches Workflow (via Arcanist) tutorial
- To submit patch via Web Interface use Patches Workflow (via Web Interface) tutorial

Description

Currently we use "safeDefine" function instead of "define". Function "safeDefine" doesn't define constant if it was previously defined to prevent fatal error. Later this function was globally used due integration issues with old kernel. Now, when it's gone we should revise usage of this function.

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

safedefine_to_define_55.2.patch
0.9 kB
04/Oct/11 5:38 AM
safedefine_to_define_55.patch
2 kB
28/Sep/11 7:25 AM

Activity

People

Assignee:

Alex

Reporter:

Alex

Developer:

Erik Snarski [Intechnic]

Votes:

0 Vote for this issue

Watchers:

0 Start watching this issue

Dates

Created:

08/Jun/09 7:27 AM

Updated:

31/Aug/13 3:31 AM

Resolved:

25/Jul/12 5:33 AM