-
Type: Bug Report
-
Status: Closed
-
Priority: Minor
-
Resolution: Fixed
-
Affects Version/s: 5.0.3
-
Fix Version/s: 5.1.0-B1
-
Component/s: Optimization
-
Labels:
-
External issue URL:
-
External issue ID:735
-
Copy Issue Key:
-
Patch Instructions:
System users "root" (id = -1) and "Guest" (id = -2) are using in In-Portal since it's first version. Despite their popularity we always use their IDs in code and not thinking about creating named constants.
I say enough to mystic numbers and propose to create constants:
- USER_ROOT - for "-1" value
- USER_GUEST - for "-2" value
I've already did that and replaced all places, where I've found that magic numbers with proposed constants.