Uploaded image for project: 'In-Portal CMS'
  1. In-Portal CMS
  2. INP-736

Link Comments are not Showing up in Admin

    XMLWordPrintable

    Details

    • Type: Bug Report
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 5.1.1-B2
    • Fix Version/s: 5.1.1-RC1
    • Component/s: Data Management
    • Labels:
      None
    • External issue URL:
    • Additional information:
      Hide

      Comments by Alex:

      I've got those notices on link review list:

      Notice (#1): Requested ID for prefix l not passed in ...\core\kernel\db\db_event_handler.php on line 327
      Notice (#2): Parent ID not found (prefix: "l"; sub-prefix: "l-rev") in ...\core\kernel\db\dblist.php on line 1017

      2nd notice is shown due changes in #771 task.

      After all it seams, that review/comments section was working normally because of the bug, that was fixed.

      Prefix "l-rev" (which is used here) is a "l" prefix subitem and therefore requires it's id for data filtering.

      To solve this quickly we need to remove filter called "parent_filter" from list based on special used on "reviews_tab" template. Notices still will be displaying in this case.

      Other way is to create another review prefix, that won't be a child for any of category item prefixes, as for now.

      Show
      Comments by Alex: I've got those notices on link review list: Notice (#1): Requested ID for prefix l not passed in ...\core\kernel\db\db_event_handler.php on line 327 Notice (#2): Parent ID not found (prefix: "l"; sub-prefix: "l-rev") in ...\core\kernel\db\dblist.php on line 1017 2nd notice is shown due changes in #771 task. After all it seams, that review/comments section was working normally because of the bug, that was fixed. Prefix "l-rev" (which is used here) is a "l" prefix subitem and therefore requires it's id for data filtering. To solve this quickly we need to remove filter called "parent_filter" from list based on special used on "reviews_tab" template. Notices still will be displaying in this case. Other way is to create another review prefix, that won't be a child for any of category item prefixes, as for now.
    • Change Log Message:
      Fixed list of Comments in Admin
    • External issue ID:
      915
    • Copy Issue Key:
    • Patch Instructions:

      Patches must be submitted through Phabricator.

      Description

      Link Comments are not Showing up in Admin.

      To Replicate - submitted a Comment (old review) on the Front-end for a Link and it's perfectly fine except I do NOT see it in the Admin -> Comments grid.

      Here is the SQL and looks like we get FALSE in WHERE which fails to
      return the list.

      SELECT inp_ItemReview.* ,(IF( ISNULL(pu.Login), IF
      (inp_ItemReview.CreatedById = -1, 'root', IF
      (inp_ItemReview.CreatedById = -2, 'Guest', 'n/a')), pu.Login )) AS
      `ReviewedBy`,(item_table.l1_Name) AS `CatalogItemName`,
      (item_table.LinkId) AS `CatalogItemId`,(ci.CategoryId) AS
      `CatalogItemCategory`,(inp_ItemReview.CreatedOn) AS `CreatedOn_date`,
      (inp_ItemReview.CreatedOn) AS `CreatedOn_time`
      FROM inp_ItemReview
      LEFT JOIN inp_PortalUser pu ON pu.PortalUserId =
      inp_ItemReview.CreatedById
      LEFT JOIN inp_Link item_table ON item_table.ResourceId =
      inp_ItemReview.ItemId
      LEFT JOIN inp_CategoryItems ci ON item_table.ResourceId =
      ci.ItemResourceId AND ci.PrimaryCat = 1
      WHERE ((FALSE) AND (inp_ItemReview.ItemType = 4))
      ORDER BY `inp_ItemReview`.`Priority`
      desc,`inp_ItemReview`.`CreatedOn` desc,`inp_ItemReview`.`ReviewText`
      asc
      LIMIT 0,11

        Attachments

          Issue Links

          child of

          Bug Report - A problem which impairs or prevents the functions of the product. INP-611 Script eats up all memory during sub-item list printing

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          mentioned in

          Page Loading...

            Activity

              People

              • Assignee:
                alex Alex
                Reporter:
                dmitry Dmitry Andrejev [Intechnic]
                Developer:
                Dmitry Andrejev [Intechnic]
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: