Uploaded image for project: 'In-Portal CMS'
  1. In-Portal CMS
  2. INP-895

Error messages are displayed on unrelated forms

    XMLWordPrintable

    Details

    • Type: Bug Report
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 5.1.2
    • Fix Version/s: 5.1.3-RC2
    • Component/s: Front End
    • Labels:
      None
    • External issue URL:
    • Additional information:
      Hide

      Not obvious things, that were changed:

      1. Unique field names were used on all forms, so instead of Email field being used everywhere now RecommendEmail, ForgotEmail, e.t.c. are used. This will help, when forms will be converted to AJAX approach using FormManager class.

      Show
      Not obvious things, that were changed: 1. Unique field names were used on all forms, so instead of Email field being used everywhere now RecommendEmail, ForgotEmail, e.t.c. are used. This will help, when forms will be converted to AJAX approach using FormManager class.
    • Change Log Message:
      Fixed error mixup from different forms in "advanced" theme
    • External issue ID:
      1095
    • Copy Issue Key:
    • Patch Instructions:

      Patches must be submitted through Phabricator.

      Description

      I've noticed, that these forms:

      • login sidebox
      • subscribe to mailing sidebox
      • recommend site sidebox
      • forgot password page

      share same user object for data validation and processing.

      Because of it if error happens on one of this forms, then it will be shown on other fields, e.g. error on "Forgot Password" form in Email field is displayed on "Recommend Site" sidebox.

      I'm proposing to assign "special" to each of sideboxes so data don't get mixed, like <inp2:u.login .../> ; <inp2:u.subscriber .../> and <inp2:u.recommend .../>

      After that error will be raised, that there is no ID in request for mentioned above Specials. Then we need to change UsersEventHandler::getPassedID method to return current GUEST user's ID for these specials.

        Attachments

          Issue Links

          parent of

          Bug Report - A problem which impairs or prevents the functions of the product. INP-912 Installation fails after "Select Modules" step

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Bug Report - A problem which impairs or prevents the functions of the product. INP-1012 Cursor isn't focused on username field on admin login form

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          relates to

          Feature Request - A new feature of the product, which has yet to be developed. INP-227 Redesign "Data Validation" Engine

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Feature Request - A new feature of the product, which has yet to be developed. INP-762 Change in "Forgot Password" logic

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Bug Report - A problem which impairs or prevents the functions of the product. INP-833 User management internals refactoring

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Bug Report - A problem which impairs or prevents the functions of the product. INP-914 Ability to reinstall In-Portal without root password

          • Major - Major loss of function.
          • Closed
          mentioned in

          Wiki Page Loading...

          Wiki Page Loading...

          Wiki Page Loading...

            Activity

              People

              • Assignee:
                alex Alex
                Reporter:
                alex Alex
                Developer:
                Alex
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: