Uploaded image for project: 'In-Commerce'
  1. In-Commerce
  2. MINC-195

Don't use "break" during shipping quote aggregation

    XMLWordPrintable

    Details

    • Type: Bug Report
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 5.1.3, 5.2.2
    • Fix Version/s: 5.2.2-B3
    • Component/s: Shipping Engine
    • Labels:
      None

      Description

      1. from "ShippingQuoteCollector::GetShippingQuotes" method extract logic inside "if (is_array($limit_types) && !in_array('ANY', $limit_types)) {" statement, that goes after "if (count($limit_types) == 0) { break; }}}" code into protected "{{applyLimitationsToShippingTypes(array $shipping_types, $limit_types)" method
      2. instead of doing "break;" when "$limit_types" array isn't empty do: $shipping_types = $this->applyLimitationsToShippingTypes($shipping_types, $limit_types);

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                alex Alex
                Reporter:
                alex Alex
                Developer:
                Erik Snarski [Intechnic]
                Reviewer:
                Alex
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 2h 28m
                  2h 28m