Index: branches/5.3.x/core/kernel/utility/debugger.php =================================================================== diff -u -N -r15677 -r15902 --- branches/5.3.x/core/kernel/utility/debugger.php (.../debugger.php) (revision 15677) +++ branches/5.3.x/core/kernel/utility/debugger.php (.../debugger.php) (revision 15902) @@ -1,6 +1,6 @@ '/temp/domviewer.html', // path to DOMViewer on website 'DOC_ROOT' => str_replace('\\', '/', realpath($_SERVER['DOCUMENT_ROOT']) ), // windows hack 'DBG_LOCAL_BASE_PATH' => 'w:', // replace DOC_ROOT in filenames (in errors) using this path + 'DBG_EDITOR_URL' => 'file://%F:%L', 'DBG_SHORTCUT' => 'F12', // Defines debugger activation shortcut (any symbols or Ctrl/Alt/Shift are allowed, e.g. Ctrl+Alt+F12) ); - // only for IE, in case if no windows php script editor defined - if (!defined('DBG_EDITOR')) { -// $dbg_constMap['DBG_EDITOR'] = 'c:\Program Files\UltraEdit\uedit32.exe %F/%L'; - $dbg_constMap['DBG_EDITOR'] = 'c:\Program Files\Zend\ZendStudio-5.2.0\bin\ZDE.exe %F'; - } - // debugger is initialized before kHTTPQuery, so do jQuery headers check here too if (array_key_exists('HTTP_X_REQUESTED_WITH', $_SERVER) && $_SERVER['HTTP_X_REQUESTED_WITH'] == 'XMLHttpRequest') { $this->_isAjax = true; @@ -936,23 +931,21 @@ * Returns link for editing php file (from error) in external editor * * @param string $file filename with path from root folder - * @param int $lineno line number in file where error is found + * @param int $line_number line number in file where error is found * @param string $title text to show on file edit link * @return string * @access public */ - public function getFileLink($file, $lineno = 1, $title = '') + public function getFileLink($file, $line_number = 1, $title = '') { if ( !$title ) { $title = str_replace('/', '\\', $this->getLocalFile($file)); } - if ( $this->isGecko() ) { - return '' . $title . ''; - } - else { - return '' . $title . ''; - } + $url = str_replace('%F', $this->getLocalFile($file), DBG_EDITOR_URL); + $url = str_replace('%L', $line_number, $url); + + return '' . $title . ''; } /** @@ -1147,7 +1140,7 @@ $value = 'no value'; } else { - $value = htmlspecialchars($this->print_r($value, true), null, 'UTF-8'); + $value = htmlspecialchars($this->print_r($value, true), ENT_QUOTES, 'UTF-8'); } echo '' . $prefix . '' . $key . '' . $value . ''; @@ -1215,7 +1208,7 @@ $this->ProfilerData[$key]['file'] = $trace_results[$i]['file']; $this->ProfilerData[$key]['line'] = $trace_results[$i]['line']; - if ( array_key_exists('object', $trace_results[$i + 1]) && isset($trace_results[$i + 1]['object']->Prefix) ) { + if ( isset($trace_results[$i + 1]['object']) && isset($trace_results[$i + 1]['object']->Prefix) ) { $object =& $trace_results[$i + 1]['object']; /* @var $object kBase */ @@ -1600,7 +1593,6 @@ $Debugger.createEnvironment(, getWindowWidth(); ?>); $Debugger.DOMViewerURL = ''; - $Debugger.EditorPath = ''; $Debugger.DebugURL = 'baseURL.'/debugger_responce.php?sid='.$this->rowSeparator.'&path='.urlencode($dbg_path); ?>'; $Debugger.EventURL = 'Factory) &&*/ $application->InitDone ? $application->HREF('dummy', '', Array ('pass' => 'm', '__NO_REWRITE__' => 1)) : ''; ?>'; $Debugger.BasePath = 'basePath; ?>';