In-Portal / branches / RC

core

Checkout Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 7
Last Commit: 17 Nov
Commits this week: 0
Total Lines of Code (LoC): 0
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 09 Jun 2009
11:39 am

Alex

1. Fixes #0000062: Remove depricated mod-rewrite parts

2. When default category item template is used (in category properties) and we are on this template on front-end, then all links to this template still contain it's name (in mod-rewrite mode only). In such case template name should be omitted from resulting url.

3. Fixed warning message in "kCategoryHelper::getCategoryModule". Message was shown, because array_intersect function was used inside array_shift function directly (temporary variable was not used).

INP-51

Options
    • -71
    • +76
    ./units/general/helpers/mod_rewrite_helper.php
    • -1
    • +2
    ./units/general/helpers/category_helper.php
    • -36
    • +21
    ./kernel/event_handler.php
    • -2
    • +2
    ./kernel/application.php
3:45 am

Alex

Fixes #0000036: Duplicate category shown at the bottom in tree frame.

Problem was in exact place I've supposed. It was related to concurrent attempts of reloading contents of same tree folder.

INP-26

Options
    • -0
    • +12
    ./admin_templates/js/tree.js
Sunday 07 Jun 2009
1:49 pm

Alex

Theme id was not set, when attempt was made to show 404 page when incorrect url was used and mod-rewrite was on.

Options
    • -1
    • +7
    ./units/general/helpers/themes_helper.php
Wednesday 03 Jun 2009
5:32 am

Alex

Fixes #0000041: User IP in UserSession table have value "0.0.0.0" sometimes.

Problem happened, because extra fields (like IP address) were stored in Session object, and not in database. In "Session::SaveData" method additional fields were assumed as "non-changed" and were not written to database at all.

INP-31

Options
    • -8
    • +9
    ./units/general/inp_ses_storage.php
    • -4
    • +7
    ./kernel/session/session.php
Sunday 31 May 2009
7:47 am

Alex

Fixes #0000005: Issue with Copy/Paste into FCK in Edit Blocks (in IE8 only)

INP-1

Options
    • -39
    • +37
    ./admin_templates/categories/edit_content.tpl
Wednesday 27 May 2009
12:47 pm

Alex

1. Fixes #0000035: Minor Adjustments to Catalog Grids.

2. Fixed JS error on category edit -> permissions tab (data was loaded, but loading indicator was not hidden).

3. Pass through variables were passed (but they should not be passed), when item was edited from "Comments" (former "Reviews") section or from "User Edit -> Items" tab. This resulted in js error in case, when category item selector was used on that item editing template.

4. New category item permission checking scheme was normally working only in administrative console, that's why for front-end old permission checking scheme restored.

5. New "View in Browse Mode" icon added/used.

INP-25

Options
    • -0
    • +40
    ./units/categories/categories_tag_processor.php
    • -0
    • +40
    ./units/general/cat_tag_processor.php
    • binary
    ./admin_templates/img/ic_browse_mode.gif
    • -1
    • +1
    ./kernel/db/db_event_handler.php
    • -21
    • +9
    ./admin_templates/catalog_tab.tpl
    • -15
    • +13
    ./admin_templates/categories/ci_blocks.tpl
    • -81
    • +86
    ./units/general/helpers/permissions_helper.php
    • -3
    • +7
    ./admin_templates/reviews/reviews.tpl
    • -1
    • +1
    ./admin_templates/categories/categories_tabs.tpl
    • -3
    • +7
    ./admin_templates/users/user_edit_items.tpl
4:15 am

Alex

Fixes #0000033: "Loading..." element while Edit Item form is loading

INP-23

Options
    • -7
    • +26
    ./admin_templates/blank.html
    • binary
    ./admin_templates/img/ajax_iframe_progress.gif
3:04 am

Alex

1. Method "kDBEventHandler::StoreSelectedIDs" wasn't returning IDs, given using $direct_ids parameter.

2. Fixes #0000025: Non-root user can't use copy/cut/paste buttons in catalog.

3. Fixed "category status propagate" feature. Now it copies category StatusField value to all it's children. Before it was coping "Status" field value to all it's children, not "StatusField" field value, specified in unit config.

INP-17

Options
    • -1
    • +1
    ./kernel/db/db_event_handler.php
    • -4
    • +30
    ./units/general/cat_event_handler.php
    • -12
    • +41
    ./units/categories/categories_event_handler.php
Tuesday 26 May 2009
10:20 am

Alex

1. Fixes 0000031: Convert FCK "Internal Link Pointers" to Real URLs.

2. Fixes 0000032: SQL Error when using FCKEditor to edit textarea data.

3. In edit templates, where HTML isn't allowed, but multi line input is required 'allow_html="0"' added to inp_edit_textarea blocks.

4. Module root categories during installation were incorrectly sorted: "Products, Topics, News, Links" instead of "Links, News, Topics, Products".

5. Fixed "Preview" button in FCKEditor, when editing content blocks:

  • problems with non-latin character encoding in javascript
  • "Preview" button were not visible during content block editing, but was visible during category description editing, where it shouldn't.

    6. Method "CategoriesTagProcessor::_replacePageIds" moved to "CategoryHelper::replacePageIds" and can be used in any place, where required.

    7. Add new field option: "using_fck". When specified, then all "@@ID@@" occurences are replaced with actual structure page urls.

INP-21

INP-22

Options
    • -35
    • +1
    ./units/categories/categories_tag_processor.php
    • -2
    • +35
    ./units/general/helpers/category_helper.php
    • -1
    • +1
    ./units/groups/groups_config.php
    • -1
    • +1
    ./units/themes/themes_config.php
    • -4
    • +4
    ./units/categories/categories_config.php
    • -1
    • +1
    ./units/forms/forms_config.php
    • -1
    • +1
    ./units/translator/translator_config.php
    • -4
    • +4
    ./units/email_messages/email_messages_config.php
    • -4
    • +9
    ./kernel/utility/formatters/multilang_formatter.php
    • -1
    • +8
    ./install/install_toolkit.php
    • -1
    • +1
    ./units/reviews/reviews_config.php
    • -1
    • +1
    ./units/phrases/phrases_config.php
    • -48
    • +43
    ./units/content/content_config.php
    • -0
    • +23
    ./units/content/content_eh.php
    • -1
    • +1
    ./admin_templates/regional/languages_edit.tpl
  16. … 10 more files in changeset.
Monday 25 May 2009
4:52 am

Alex

Method "kDBEventHandler:getPassedID" failed to return correct ID, when "special" was used and method "kDBEventHandler::StoreSelectedIDs" was not called before it (like in OnEdit event).

Options
    • -1
    • +1
    ./kernel/db/db_event_handler.php
Saturday 23 May 2009
4:03 am

Alex

1. Additional parameters to PrintList2 tag:

  • "limit" (input) - tells, how many of queried from database records should be actually displayed.
  • "num" (output) - record number (relative to queried record count).
  • "last_row" (output) - tells, that current record is located in last row (when printing records in table)

    2. "no_next_page_render_as" parameter added to PrintPages tag.

    3. GridInfo tag fixed, so it doesn't report, that pagination is required, when pagination is not used (per_page="-1" in InitList/PrintList tag).

Options
    • -1
    • +3
    ./kernel/db/db_event_handler.php
    • -2
    • +11
    ./kernel/db/db_tag_processor.php
Wednesday 20 May 2009
3:31 am

Alex

Bug #0000009: Admin: Duplicate Link Checker.

1. Allows to use base64_encode function result as ID in grids.

2. Deprecated "adm_SaveReturnScript" tag removed.

3. When grid with special was used and event raised from grid (like OnPreCreate or OnNew) performed redirect, when first selected item ID was not passed in redirect link.

4. Private method "kCatDBEventHandler::_getMassPermissionEvents" added. Method allows category item event handlers to add own events to permission checking.

MINL-1

Options
    • -16
    • +0
    ./units/admin/admin_tag_processor.php
    • -2
    • +0
    ./admin_templates/logs/visits/visits_list.tpl
    • -1
    • +2
    ./kernel/db/db_event_handler.php
    • -1
    • +1
    ./admin_templates/incs/grid_blocks.tpl
    • -5
    • +14
    ./units/general/cat_event_handler.php
3:21 am

Alex

Fixes #0000006: Left Tree with Sections Fails to Update.

1. Tree also was not refreshed automatically, when "Approve" & "Decline" (changed show in menu status), "Move Up" & "Move Down" (changed priority) toolbar buttons were used.

INP-2

Options
    • -8
    • +2
    ./admin_templates/catalog/catalog_counters.tpl
    • -9
    • +1
    ./admin_templates/catalog_tab.tpl
    • -0
    • +2
    ./units/categories/categories_event_handler.php
    • -0
    • +14
    ./admin_templates/categories/ci_blocks.tpl
3:11 am

Alex

Fixes #0000008: Limiting "Form Creator" to DBG Mode.

1. Added new configuration variable "DebugOnlyFormConfigurator" (in "Configuration -> Website Settings -> Advanced" section).

INP-4

Options
    • -0
    • +3
    ./install/upgrades.sql
    • -0
    • +1
    ./install/english.lang
    • -0
    • +2
    ./install/install_data.sql
    • -0
    • +10
    ./admin_templates/tree.tpl
2:45 am

Alex

bug #0000007 fixed - Switching between Catalog / Show All grids

INP-3

Options
    • -1
    • +1
    ./admin_templates/catalog/item_selector/item_selector_catalog.tpl
    • -1
    • +1
    ./admin_templates/catalog/advanced_view.tpl
    • -1
    • +2
    ./admin_templates/js/catalog.js
    • -1
    • +1
    ./admin_templates/catalog/catalog.tpl
    • -1
    • +1
    ./admin_templates/catalog/item_selector/item_selector_advanced_view.tpl
    • -1
    • +1
    ./admin_templates/reviews/reviews.tpl
    • -4
    • +10
    ./admin_templates/tree.tpl
    • -1
    • +1
    ./admin_templates/users/user_edit_items.tpl
    • -1
    • +1
    ./admin_templates/categories/categories_edit_permissions.tpl
Tuesday 19 May 2009
3:20 am

Alex

Tag "kDBTagProcessor::SelectParam" now also skips parameter value, when it's equals to "0" (zero).

Options
    • -1
    • +1
    ./kernel/processors/tag_processor.php
Monday 18 May 2009
4:13 am

Alex

1. Method "kDBEventHandler::UseTempTables" wasn't getting actual main item's special when temp handler were deleting subitems.

2. Fixed bug in previous fix of JSONHelper class: strings were enclosed with single quotes, but single quotes were not escaped in string content.

Options
    • -6
    • +18
    ./kernel/db/db_event_handler.php
    • -1
    • +1
    ./units/general/helpers/json_helper.php
Sunday 17 May 2009
3:20 pm

Alex

1. When item ID was 0 (new main item creation) method "kDBEventHandler::getPassedID" wasn't returning it. Though such ID was returned by "kDBEventHandler::StoreSelectedIDs", that was called later from "kDBEventHandler::getPassedID" method.

2. Foreign key value for subitem WITH SPECIAL wasn't set in kDBEventHandler::OnNew event and 2 warnings were shown.

3. Temp mode mark (<prefix_special>_mode variable) in method "kDBEventHandler::setTempWindowID" was not passed to item editing/creation window, when in both grid and item edit template special was used.

4. Fixed bug in "kDBTagProcessor::FieldVisible" resulting 2 warnings where VerifyPassword field visibility was checked. This is only virtual field, that doesn't exist in unit config and is created on the fly by kPasswordFormatter class.

5. Specials used in "events" request variable were stripped, before adding to "passed" request variable in method "kEventManager::ProcessRequest". Because of such behavior data associated with stripped specials (like temp mode mark and item's ID) were not available in "m_Link" tag used with 'pass="all"' parameter. Fixed by removing such stripping in administrative console only.

6. Prefix data passed in POST wasn't able to overwrite prefix data passed in GET in case, when special was used. This caused problems during item editing when special was used in grid and item edit template.

7. Missing "noimage.gif" image added.

Options
  1. ./admin_templates
    • -7
    • +21
    ./kernel/db/db_event_handler.php
  3. ./admin_templates/js
  4. ./admin_templates/themes
  5. ./admin_templates/js/jquery
    • -3
    • +12
    ./kernel/event_manager.php
  7. ./units
    • -0
    • +32
    ./kernel/utility/http_query.php
    • -3
    • +6
    ./kernel/kbase.php
    • -0
    • +5
    ./kernel/db/db_tag_processor.php
  11. … 1 more file in changeset.
Wednesday 13 May 2009
4:54 am

Alex

1. #27493 - Admin: Add Item on Advanced View

2. OnCancel event was called on "categories/categories_edit" template instead of "OnCancelEdit" resulting no temporary table was deleted.

3. Method kApplication::ConfigValue fixed. Now if variable value is present, but it has NULL as value, then such variable is not threated as missing and duplicate queries are performed.

TODO: replace all NULL values in ConfigurationValues table with default values based on variable type (0 for checkbox, empty string for text and so on)

4. Now kDBEventHandler::StoreSelectedIDs could also get IDs from new "ids" $event parameter, rather, then from request. Useful, when IDs are changed on kDBEventHandler::CheckPermission method (before actual event call).

5. Method CategoryHelper::getStructureTreeAsOptions added. Method provides ability to get all category structure as options for any dbitem field (like ParentId for categories and CategoryId for category items).

6. Method CustomFieldsEventHandler::_getHiddenFiels fixed. Now it doesn't given warning when editing category item, with no custom fields to show on general tab.

7. Fixed method kCatDBItem::MoveToCat. Now, when category item is in temp mode, then category manipulations are also made in temp tables.

8. Permission checking logic for categories and category items in temp table is changed. Now everything in temp tables for them is allowed. Permissions are checked only when Save button is pressed during main item (not subitem) editing. When user selected 5 items, but he can edit only 2 of them, then other 3 are automatically excluded from item edit form. When all of selected items are excluded, then user gets "no permission" screen. Same with "move up/down", "approve/decline" toolbar buttons.

9. Method CategoriesEventHandler::printChildren && CategoriesEventHandler::getChildren moved to CategoryHelper and now are used by new CategoryHelper::getStructureTreeAsOptions method. Some documentation added for other CategoryHelper methods.

10. Permission debugging information was not available in some of permission checking methods. That's why method kPermissionHelper::finalizePermissionCheck added. Method should be used in any place, when $event status should change to erPERM_FAIL.

11. Column filters on Category Edit -> Custom tab's grid were not working, because of incorrect grid name used (Default instead of SeparateTab).

12. Fixed title preset name in "products/products_access" template (was "pr", but should be "access").

13. Fixed incorrect pagination prefix in some templates.

14. Formatter added for OnSale field in Products table.

15. No permission template fixed, now it doesn't break catalog.

16. sections_list template fixed to use new blocks.

Options
    • -6
    • +17
    ./units/admin/admin_tag_processor.php
    • -2
    • +17
    ./admin_templates/catalog/advanced_view.tpl
    • -0
    • +175
    ./units/general/helpers/category_helper.php
    • -1
    • +1
    ./admin_templates/categories/categories_edit_relations.tpl
    • -14
    • +29
    ./admin_templates/no_permission.tpl
    • -2
    • +2
    ./units/categories/categories_config.php
    • -18
    • +5
    ./admin_templates/sections_list.tpl
    • -1
    • +1
    ./admin_templates/categories/categories_edit_related_searches.tpl
    • -7
    • +2
    ./admin_templates/catalog_tab.tpl
    • -1
    • +1
    ./admin_templates/categories/cache_updater.tpl
    • -2
    • +2
    ./units/custom_fields/custom_fields_event_handler.php
    • -2
    • +2
    ./admin_templates/categories/categories_edit.tpl
    • -1
    • +1
    ./admin_templates/categories/categories_edit_custom.tpl
    • -90
    • +135
    ./units/general/helpers/permissions_helper.php
    • -1
    • +1
    ./admin_templates/categories/categories_edit_properties.tpl
  16. … 15 more files in changeset.
Tuesday 12 May 2009
8:12 am

Alex

1. #27504 - Admin: Left Tree -> Add 2px Padding-Right to Elements

2. Skin name made requred.

Options
    • -1
    • +1
    ./units/skins/skins_config.php
    • -1
    • +1
    ./install/install_data.sql
    • -1
    • +1
    ./admin_templates/incs/style_template.css
2:27 am

Alex

1. Special "primary" added for "skin" prefix for easy primary skin accessing.

2. Fixed some issues with uploaded/resized image path building, when WriteableBase was "\system" on Windows.

Options
    • -2
    • +2
    ./units/admin/admin_tag_processor.php
    • -1
    • +2
    ./kernel/db/db_event_handler.php
    • -2
    • +2
    ./units/general/helpers/image_helper.php
    • -5
    • +5
    ./kernel/utility/formatters/upload_formatter.php
    • -0
    • +25
    ./units/skins/skin_eh.php
Sunday 10 May 2009
4:13 pm

Alex

1. Added submenu item in "Catalog -> Tools" menu for rebuilding priorities cache in current category

2. "View in Browse Mode" link is now hidden from catalog item selector.

3. Added missing js_escape parameter to phrases used in javascript in combined_header block.

4. Fixed bad automatic thickbox window positioning, when firebug or bookmark panel was opened (iframe was moving outside it's window).

5. New parameter $onAfterOpenPopup added for js functions: std_precreate_item, std_new_item, std_edit_temp_item.

6. inp_edit_box_ml block was used on non-multilanguage field (for prefix "skin", "test").

7. Improvements in installator & unit config reader for windows (DIRECTORY_SEPARATOR was used insead of "/" that was hardcoded). Iproved file scanning operation performance.

8. Installation on linux failed on 2nd step, when config.php file was missing and attempt was made to check it's write permissions.

9. kDBConnection::doInsert method iproved, so it now can perform multiple record insert into same table using only one INSERT statement no matter what actual records will be inserted.

10. Removed unused code from kDBTagProcessor::PredefinedSearchOptions tag

11. Now grid filters are not affected by DefaultSettingUsedId configuration variable.

12. Fixed Debugger::netMatch method. Now it doesn't raise warnings every time, when compare 2 given ip addresses (not subnet masks as earlier).

13. Improved config file search engine, now it takes 1 second to scan all config file for all in-portal modules.

14. preg_match in kUnitConfigReader::configAllowed replaced with substr, that improved config file checking speed.

15. Fixed bug in "Content" removal in each category path (was not removed, when only Content was present in category path).

16. Fixed bug in ExportHelper, that asked item for ExportColumns field even, when such field was not available.

17. When installed on local domain (tested on windows), then paid modules were not available at all, but they should be available for installing.

Options
    • -1
    • +9
    ./units/categories/categories_tag_processor.php
    • -1
    • +1
    ./units/general/cat_tag_processor.php
    • -524
    • +0
    ./units/languages/import_xml.php
    • -0
    • +583
    ./units/general/helpers/language_import_helper.php
    • -9
    • +34
    ./kernel/db/db_connection.php
    • -1
    • +2
    ./units/email_messages/email_messages_config.php
    • -0
    • +4
    ./kernel/utility/factory.php
    • -0
    • +5
    ./install/english.lang
    • -3
    • +1
    ./admin_templates/skins/skin_edit.tpl
    • -2
    • +2
    ./units/users/users_config.php
    • -1
    • +4
    ./units/general/helpers/sections_helper.php
    • -1
    • +1
    ./install/upgrades.sql
    • -2
    • +2
    ./admin_templates/incs/form_blocks.tpl
    • -2
    • +2
    ./units/general/helpers/search_helper.php
    • -0
    • +11
    ./admin_templates/catalog/catalog.tpl
  16. … 21 more files in changeset.
Friday 08 May 2009
6:10 am

vnikita

      • empty log message ***
Options
    • -0
    • +2
    ./admin_templates/skins/skin_edit.tpl
Thursday 07 May 2009
4:26 am

Alex

Fixed problem in JSONHelper, when string with only numbers inside beginning with leading zeros was encoded as number and leading zeros were lost as a result.

Options
    • -13
    • +10
    ./units/general/helpers/json_helper.php
Wednesday 06 May 2009
11:42 am

Alex

1. #27081 - Admin: Editor in Site Views fix

2. kDateFormatter doesn't create *_formatted virtual fields anymore.

Options
    • -1
    • +1
    ./units/admin/admin_tag_processor.php
    • -1
    • +1
    ./admin_templates/catalog/advanced_view.tpl
    • -9
    • +11
    ./units/general/cat_dbitem.php
    • -1
    • +1
    ./units/categories/categories_config.php
    • -4
    • +0
    ./admin_templates/incs/grid_blocks.tpl
    • -1
    • +3
    ./admin_templates/js/template_manager.js
    • -3
    • +3
    ./units/structure/structure_config.php
    • -5
    • +5
    ./kernel/utility/formatters/date_formatter.php
    • -7
    • +19
    ./install/upgrades.php
6:34 am

Alex

1. Fixed bug, when catalog grid filter raised fatal error when using category selector.

Options
    • -2
    • +2
    ./units/categories/categories_config.php
5:56 am

Alex

#27465 - Admin: All Grids -> Broken Size for Field with Checkboxes

Options
    • -6
    • +6
    ./admin_templates/incs/grid_blocks.tpl
4:51 am

Alex

#27462 - License Check for Modules

Options
    • -7
    • +30
    ./units/general/helpers/modules.php
    • -1
    • +0
    ./units/users/users_event_handler.php
    • -2
    • +10
    ./kernel/application.php
4:13 am

Alex

FieldVisible tag added to all local copies of blocks (copied from form_blocks and then changed)

Options
    • -1
    • +1
    ./admin_templates/stylesheets/base_style_edit.tpl
    • -16
    • +18
    ./admin_templates/regional/languages_edit.tpl
    • -1
    • +1
    ./admin_templates/stylesheets/block_style_edit.tpl
    • -2
    • +2
    ./admin_templates/stylesheets/style_editor.tpl
    • -1
    • +1
    ./admin_templates/regional/languages_export_step2.tpl
    • -1
    • +1
    ./admin_templates/submissions/submission_view.tpl
    • -1
    • +1
    ./admin_templates/emails/send_complete.tpl
    • -182
    • +182
    ./admin_templates/skins/skin_edit.tpl
    • -1
    • +1
    ./admin_templates/emails/mass_mail.tpl
    • -1
    • +1
    ./admin_templates/incs/custom_blocks.tpl
    • -10
    • +12
    ./admin_templates/categories/ci_blocks.tpl
    • -7
    • +9
    ./admin_templates/regional/languages_export.tpl
    • -13
    • +15
    ./admin_templates/mailing_lists/mailing_list_edit.tpl
3:07 am

Alex

1. Fixed category edit template layout in IE -> hidden fields moved outside table to look normal.

2. Fixed ajax overlay zIndex, so new windows will open over it, not under it as before.

3. Content category stripped from exported data.

4. Use is redirected exactly to import target category (not just in home category as before) after import is made.

5. #27456 - Admin: Import -> Multiple Fixes

Options
    • -2
    • +20
    ./units/admin/admin_tag_processor.php
    • -0
    • +9
    ./admin_templates/catalog/advanced_view.tpl
    • -2
    • +2
    ./units/categories/categories_config.php
    • -1
    • +0
    ./admin_templates/sections_list.tpl
    • -1
    • +1
    ./admin_templates/categories/categories_edit.tpl
    • -8
    • +8
    ./install/install_toolkit.php
    • -0
    • +1
    ./units/general/helpers/permissions_helper.php
    • -2
    • +9
    ./admin_templates/modules/modules_list.tpl
    • -1
    • +12
    ./admin_templates/tools/import1.tpl
    • -2
    • +13
    ./admin_templates/tools/import2.tpl
    • -1
    • +19
    ./units/general/cat_dbitem_export.php
    • -18
    • +43
    ./units/general/cat_event_handler.php
    • -0
    • +9
    ./admin_templates/catalog/catalog.tpl
    • -18
    • +1
    ./units/categories/categories_event_handler.php
    • -0
    • +9
    ./kernel/db/db_tag_processor.php
    • -1
    • +1
    ./admin_templates/js/ajax.js